Skip to content

Conversation

@dfawley
Copy link
Member

@dfawley dfawley commented Apr 11, 2024

cc @PapaCharlie

RELEASE NOTES:

  • stats: deprecate InPayload.Data and OutPayload.Data; they were experimental and will be deleted in the next release

@dfawley dfawley added the Type: API Change Breaking API changes (experimental APIs only!) label Apr 11, 2024
@dfawley dfawley added this to the 1.64 Release milestone Apr 11, 2024
@dfawley dfawley requested a review from zasweq April 11, 2024 18:07
@PapaCharlie
Copy link
Contributor

Thanks for this! LGTM. While you're in there, I think it should also probably be explicitly documented that the Payload field can also be modified after HandleRPC returns since it will be handed over to the user code. If the handler needs access to it after the fact, it needs to be copied.

@dfawley
Copy link
Member Author

dfawley commented Apr 11, 2024

I think it should also probably be explicitly documented that the Payload field can also be modified after HandleRPC returns since it will be handed over to the user code. If the handler needs access to it after the fact, it needs to be copied.

Done!

@zasweq zasweq assigned dfawley and unassigned zasweq Apr 11, 2024
@dfawley dfawley merged commit 664e852 into grpc:master Apr 11, 2024
@dfawley dfawley deleted the stats branch April 11, 2024 20:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Type: API Change Breaking API changes (experimental APIs only!)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants