Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Feb 27, 2024

RELEASE NOTES: none

Signed-off-by: Matthieu MOREL [email protected]

@codecov
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Merging #7004 (a2240db) into master (5ccf176) will decrease coverage by 0.15%.
The diff coverage is 87.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7004      +/-   ##
==========================================
- Coverage   82.43%   82.29%   -0.15%     
==========================================
  Files         296      296              
  Lines       31473    31455      -18     
==========================================
- Hits        25946    25887      -59     
- Misses       4468     4500      +32     
- Partials     1059     1068       +9     
Files Coverage Δ
channelz/service/func_linux.go 85.36% <100.00%> (ø)
channelz/service/service.go 83.54% <100.00%> (-1.17%) ⬇️
xds/internal/xdsclient/bootstrap/bootstrap.go 74.48% <33.33%> (ø)

... and 17 files with indirect coverage changes

@mmorel-35 mmorel-35 marked this pull request as ready for review February 27, 2024 13:40
@dfawley
Copy link
Member

dfawley commented Feb 27, 2024

The changes to channelz will conflict with #6969, so I'd rather do them later (as that is a huge PR), and the other changes you've made are already included in #6961.

Thank you for the PR, though!

@dfawley dfawley closed this Feb 27, 2024
@mmorel-35 mmorel-35 deleted the protobuf branch February 27, 2024 18:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants