Skip to content

transport: when using write buffer pooling, use input size instead of size*2 #6983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 15, 2024
Merged

transport: when using write buffer pooling, use input size instead of size*2 #6983

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3603c49
Create buffers of input size instead of *2
raghav-stripe Feb 15, 2024
b7693f2
Revert "Create buffers of input size instead of *2"
raghav-stripe Feb 15, 2024
36c6ea1
Update docstring to remove 2x buffer size allocation info
raghav-stripe Feb 15, 2024
be9e69b
Reapply "Create buffers of input size instead of *2"
raghav-stripe Feb 15, 2024
0a08b0e
Fix formatting
raghav-stripe Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/transport/http_util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,10 +418,9 @@ func newFramer(conn net.Conn, writeBufferSize, readBufferSize int, sharedWriteBu
return f
}

func getWriteBufferPool(writeBufferSize int) *sync.Pool {
func getWriteBufferPool(size int) *sync.Pool {
writeBufferMutex.Lock()
defer writeBufferMutex.Unlock()
size := writeBufferSize * 2
pool, ok := writeBufferPoolMap[size]
if ok {
return pool
Expand Down