security/advancedtls: fix test that relies on min TLS version #6824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Go 1.22 changed the default TLS minimum version. Toolchains which do not respect go.mod 'go' version directives will break when executing the Test/GetCertificatesSNI/Select_serverCert3 test, since it relies on the private tls.ClientHelloInfo.config fields minimum version matching the configured tls.ClientHelloInfo.SupportedVersions field. This change just bumps the version in tls.ClientHelloInfo.SupportedVersions to tls.VersionTLS12. This fixes an internal google test.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6824 +/- ##
==========================================
- Coverage 83.58% 83.51% -0.07%
==========================================
Files 285 285
Lines 30879 30879
==========================================
- Hits 25811 25790 -21
- Misses 4005 4023 +18
- Partials 1063 1066 +3 |
erm-g
approved these changes
Dec 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.22 changed the default TLS minimum version. Toolchains which do not respect go.mod 'go' version directives will break when executing the Test/GetCertificatesSNI/Select_serverCert3 test, since it relies on the private tls.ClientHelloInfo.config fields minimum version matching the configured tls.ClientHelloInfo.SupportedVersions field. This change just bumps the version in tls.ClientHelloInfo.SupportedVersions to tls.VersionTLS12.
With Go 1.22, gRPC users will still be able to use TLS versions VersionTLS10, VersionTLS11 by utilizing MinVersion and MaxVersion parameters of ClientOptions struct.
b/315783527
RELEASE NOTES: N/A