balancer/weightedroundrobin: fix ticker leak on update #6643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that regenerate the picker, called on every conn update, does creates ticker to update weights but does not properly close it. This causes resource leaks. Fix this by properly stopping the ticker.
easwars
changed the title
dfawley
approved these changes
Sep 18, 2023
easwars
approved these changes
Sep 18, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that regenerate the picker, called on every conn update, does creates ticker to update weights but does not properly close it. This causes resource leaks.
Fix this by properly stopping the ticker.
RELEASE NOTES: n/a