Skip to content

tests: stop using UpdateSubConnState #6527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dfawley merged 1 commit into from
Aug 9, 2023
Merged

tests: stop using UpdateSubConnState #6527

dfawley merged 1 commit into from
Aug 9, 2023

Conversation

@dfawley
Copy link
Member

@dfawley dfawley commented Aug 9, 2023

A future change will delete stub.BalancerFuncs.UpdateSubConnState... This prepares for that and uses StateListener instead.

RELEASE NOTES: none

@dfawley dfawley added this to the 1.58 Release milestone Aug 9, 2023
@dfawley dfawley requested a review from arvindbr8 August 9, 2023 20:31
arvindbr8
arvindbr8 approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dfawley dfawley merged commit 8f51ca8 into grpc:master Aug 9, 2023
@dfawley dfawley deleted the uscs_test branch August 9, 2023 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arvindbr8 arvindbr8

Labels

Type: Testing

Projects

None yet

Milestone

1.58 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@dfawley @arvindbr8