clusterresolver: remove redundant tests #6388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
approved these changes
Jun 22, 2023
Contributor
zasweq
left a comment
zasweq
left a comment
There was a problem hiding this comment.
LGTM. I noticed yesterday writing tests for the server feature we have a lot of mocks that verify calls into mocks.
Contributor
Author
Is that related in any way to this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two tests which are redundant:
TestClientWatchEDSis already covered by an e2e testTestEDS_ClusterResourceUpdatesTestFallbackToDNSis covered by an e2e testTestAggregateCluster_BadEDS_BadDNS#resource-agnostic-xdsclient-api
RELEASE NOTES: none