xds: Replace IsTerminal() check with IsRouterFilter() check #6281
Conversation
Since all legal tests in unmarshal_lds_test.go explicitly use a router filter as the terminal filter Have accordingly modified the "last not terminal filter" testcase to be the "last not router filter" test
|
hi @easwars, could you please review the changes? I didn't create a new |
|
hi @easwars, is there any further action required from my end? |
Hi @Aditya-Sood |
| }), | ||
| wantName: v3LDSTarget, | ||
| wantErr: "is not a terminal filter", | ||
| wantErr: "is not a router filter", |
There was a problem hiding this comment.
Just to be exhaustive, can we have a test where the last filter is a terminal filter, but it is just not the router filter.
There was a problem hiding this comment.
got it @easwars, will update once it's done
thank you
|
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
|
commenting to refresh bot's PR status |
|
As per the discussion on #6248, the xDS Client handling is correct here. What we really want to get rid of is the no-op check in newInterceptor() mentioned in discussion. Thus, I am closing this PR for now. Thank you for the contribution though! |
4 participants
Fixes #6259
RELEASE NOTES: none