Skip to content

channelz: use protocmp.Transform() to compare protos #6065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
easwars merged 1 commit into from
Feb 28, 2023
Merged

channelz: use protocmp.Transform() to compare protos #6065

easwars merged 1 commit into from
Feb 28, 2023

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Feb 28, 2023

Code in google3 panics when cmpopts.IgnoreUnexported is used for protos instead of protocmp.Transform. The internal version of the cmp package is smarter. See here.

RELEASE NOTES: none

@easwars easwars requested a review from arvindbr8 February 28, 2023 19:43
@easwars easwars added this to the 1.54 Release milestone Feb 28, 2023
@easwars easwars merged commit 832ecc2 into grpc:master Feb 28, 2023
@easwars easwars deleted the channelz_protocmp branch February 28, 2023 21:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@arvindbr8 arvindbr8

Labels

Type: Testing

Projects

None yet

Milestone

1.54 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@easwars @arvindbr8