gcp/observability: Register new views #6026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
force-pushed
the
fix-o11y-callsite
branch
from
f150aea to
d34255e
Compare
dfawley
approved these changes
Feb 16, 2023
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
How did this pass the integration tests before?
Please make sure it continues to pass before merging.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the observability module to use the new views in the new instrumentation code rather than the old ones. It adds all the views that are currently present defined in Yashes list of metrics for GA. The views needed to still be added are the Compressed Sent/Recv for both client and server (we have uncompressed equivalents), and also per call latency, which is in flight in #6017.
RELEASE NOTES: N/A