Skip to content

alts: do not set WaitForReady on handshaker service RPCs #5620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 31, 2022
Merged

alts: do not set WaitForReady on handshaker service RPCs #5620

merged 1 commit into from
Aug 31, 2022

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Aug 31, 2022

RELEASE NOTES:

  • alts: fix a bug which was setting WaitForReady on handshaker service RPCs, thereby delaying fallback when required

@easwars easwars requested a review from dfawley August 31, 2022 18:17
@easwars easwars added this to the 1.50 Release milestone Aug 31, 2022
@dfawley dfawley assigned easwars and unassigned dfawley Aug 31, 2022
@easwars easwars merged commit ddcda5f into grpc:master Aug 31, 2022
@easwars easwars deleted the alts_handshaker branch August 31, 2022 21:37
@moul-bot moul-bot mentioned this pull request Oct 7, 2022
Closed
@moul-bot moul-bot mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels

Type: Bug

Projects

None yet

Milestone

1.50 Release

Development

Successfully merging this pull request may close these issues.

2 participants

@easwars @dfawley