Skip to content

ringhash: implement a no-op ExitIdle() method #5614

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2022
Merged

ringhash: implement a no-op ExitIdle() method #5614

merged 1 commit into from
Aug 30, 2022

Conversation

@easwars
Copy link
Contributor

@easwars easwars commented Aug 29, 2022 •
edited by dfawley
Loading

Fixes #5602

RELEASE NOTES:

  • ringhash: do nothing when asked to exit IDLE instead of falling back on the default channel behavior of connecting to all addresses

@easwars easwars added this to the 1.50 Release milestone Aug 29, 2022
@easwars easwars requested a review from dfawley August 29, 2022 23:16
@dfawley dfawley assigned easwars and unassigned dfawley Aug 29, 2022
@dfawley
Copy link
Member

dfawley commented Aug 29, 2022

(Also edited relnotes)

@easwars easwars merged commit 1dd0256 into grpc:master Aug 30, 2022
@easwars easwars deleted the ringhash_exitidle branch August 30, 2022 00:23
@easwars easwars mentioned this pull request Sep 14, 2022
Merged
@moul-bot moul-bot mentioned this pull request Oct 7, 2022
Closed
@moul-bot moul-bot mentioned this pull request Oct 17, 2022
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels

Type: Bug

Projects

None yet

Milestone

1.50 Release

Development

Successfully merging this pull request may close these issues.

ringhash: implement the ExitIdler interface

2 participants

@easwars @dfawley