interop testing: log the peer address in interop soak client#5419
Merged
Conversation
easwars
reviewed
Jun 16, 2022
| } | ||
|
|
||
| func doOneSoakIteration(ctx context.Context, tc testgrpc.TestServiceClient, resetChannel bool, serverAddr string, dopts []grpc.DialOption) (latency time.Duration, err error) { | ||
| func doOneSoakIteration(ctx context.Context, tc testgrpc.TestServiceClient, resetChannel bool, serverAddr string, dopts []grpc.DialOption) (latency time.Duration, peer peer.Peer, err error) { |
Contributor
There was a problem hiding this comment.
I admit this is existing art, but naked returns are not ideal for anything other than really small functions.
See: go/go-style/decisions#named-result-parameters
Not asking you change that in this PR, but if we can avoid adding more named result parameters to this function, that would be nice.
One option is to pass call options to this function. So, something like this:
func doOneSoakIteration(ctx context.Context, tc testgrpc.TestServiceClient, resetChannel bool, serverAddr string, dopts []grpc.DialOption, copts []grpc.CallOption) (latency time.Duration, err error) {
...
reply, err = client.UnaryCall(ctx, req, copts...)
...
}And then, the caller can create the peer.Peer, pass it as a CallOption to this function, and inspect the former after the RPC. What do you think?
easwars
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps debugging and makes it easy to set up tests that inspect the RPC distribution across different backends.
I've opened grpc/grpc#30012 to document this logging output across languages.
RELEASE NOTES: none