Use exact size, if known, to allocate decompression buffer #3048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For large messages this generates far less garbage than ioutil.ReadAll(). Implement for gzip - RFC1952 requires it, and the Go implementation checks it already (modulo 2^32). Signed-off-by: Bryan Boreham <[email protected]>
bboreham
force-pushed
the
exact-decompress-size
branch
from
e36a434 to
4d7f286
Compare
dfawley
added
the
Type: Performance
dfawley
reviewed
Sep 27, 2019
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
Thanks for the new version, this is even better!
Return -1 instead of an error in the case that we can't determine a size. Use a LimitReader set to size+1 so we can detect cases like corrupt messages and overflow of the 32-bit size field. Signed-off-by: Bryan Boreham <[email protected]>
Based on review feedback Signed-off-by: Bryan Boreham <[email protected]>
Contributor
Author
|
I pushed a couple more commits which I think cover all the review comments. |
dfawley
reviewed
Oct 3, 2019
Signed-off-by: Bryan Boreham <[email protected]>
dfawley
reviewed
Oct 4, 2019
Member
dfawley
left a comment
dfawley
left a comment
There was a problem hiding this comment.
LGTM. One last minor change to request for initializing buf first, though. Thanks!
It's simpler. Signed-off-by: Bryan Boreham <[email protected]>
dfawley
approved these changes
Oct 4, 2019
Member
|
Thanks for the contribution! |
bboreham
added a commit
to cortexproject/cortex
that referenced
this pull request
Nov 8, 2019
This brings in some performance improvements, including grpc/grpc-go#3048 which should make a big difference when using gRPC gzip compression. Plus some updated dependencies. Signed-off-by: Bryan Boreham <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2635
For large messages this generates far less garbage than
ioutil.ReadAll().Implement for gzip - RFC1952 requires it, and the Go implementation checks it already (modulo 2^32).