Skip to content

credentials/alts: Panic Bug Fix #2800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 3, 2019
Merged

credentials/alts: Panic Bug Fix #2800

merged 1 commit into from
May 3, 2019

Conversation

@cesarghali
Copy link
Contributor

@cesarghali cesarghali commented May 3, 2019

Using defer before checking NewClientHandshake and NewServerHandshake error can cause panic. If these two APIs failed, chs and shs will be nil when Close is called.

@cesarghali cesarghali requested a review from menghanl May 3, 2019 17:24
@cesarghali cesarghali merged commit 4b60e3b into grpc:master May 3, 2019
@cesarghali cesarghali deleted the fix_alts_bug branch May 3, 2019 17:48
@lock lock bot locked as resolved and limited conversation to collaborators Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@menghanl menghanl menghanl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@menghanl menghanl

Labels

Type: Internal Cleanup Refactors, etc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cesarghali @menghanl