google.golang.org/grpc/xds has dependency on "testing"

[aaronbee]

What version of gRPC are you using?

v1.53.0

What version of Go are you using (go version)?

v1.19.5

What operating system (Linux, Windows, …) and version?

N/A

What did you do?

We check for imports of unexpected dependencies for our production binaries. Upgrading to grpc v1.53.0 added an import to the standard library "testing" package.

What did you expect to see?

Production libraries should not depend on "testing".

What did you see instead?

This is one dependency path seen:

google.golang.org/grpc/xds/googledirectpath ->
google.golang.org/grpc/xds ->
google.golang.org/grpc/xds/internal/balancer ->
google.golang.org/grpc/xds/internal/balancer/cdsbalancer ->
google.golang.org/grpc/xds/internal/balancer/clusterresolver ->
google.golang.org/grpc/internal/testutils ->
testing

"google.golang.org/grpc/xds/internal/balancer/clusterresolver" likely is not supposed to depend on "google.golang.org/grpc/internal/testutils". In This #5852 resource_resolver_dns.go added a call to testutils.MustParseURL.

[dfawley]

Sounds right. Thanks for catching this!

[dfawley]

@easwars could you take a look please?

[gm42]

google.golang.org/grpc/channelz/service is also importing google.golang.org/grpc/internal/testutils, which in turn imports testing; I'll try to come up with a PR.

[gm42]

Opened PR #6027; if someone could fix the missing label/milestone and review it, that'd be appreciated. Thanks!