Fix UpdateBalancingState not called when address attributes are modified#2553
Merged
JamesNK merged 3 commits intogrpc:masterfrom Oct 9, 2024
Merged
Fix UpdateBalancingState not called when address attributes are modified#2553JamesNK merged 3 commits intogrpc:masterfrom
JamesNK merged 3 commits intogrpc:masterfrom
Conversation
JamesNK
force-pushed
the
SubchannelsLoadBalancerTests
branch
from
8736ee5 to
41b297d
Compare
Member
Author
|
Ready for review. I know grpc-web test is failing. Will fix it once RC2 is public. |
amcasey
approved these changes
Oct 8, 2024
Contributor
amcasey
left a comment
amcasey
left a comment
There was a problem hiding this comment.
The code seems to match the description and the description seems reasonable.
|
|
||
| var allUpdatedSubchannels = new List<AddressSubchannel>(); | ||
| var newSubchannels = new List<Subchannel>(); | ||
| var modifiedSubchannelsCount = 0; |
Contributor
There was a problem hiding this comment.
It doesn't seem important either way, but it looks like this could be a simple bool.
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
Closed
This was referenced Aug 17, 2025
This was referenced Oct 12, 2025
This was referenced Nov 14, 2025
This was referenced Nov 24, 2025
Closed
This was referenced Dec 8, 2025
This was referenced Dec 19, 2025
Closed
This was referenced Jan 12, 2026
This was referenced Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC load balancing would update subchannels with modified address attributes when they changed, but the overall channel state was never updated.