Skip to content

Conversation

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jul 16, 2023

This PR significantly improves the debugging experience of gRPC calls. Changes have been applied in many places. There are before and after screenshots of each.

ServerCallContext

Before:

image

After:

image

Server StreamReader

Before:

image

After:

image

Server StreamWriter

Before:

image

After:

image

Client call

Before:

After:

image

Client StreamReader

Before:

image

After:

image

Client StreamWriter

Before:

image

After:

image

Metadata

Before:

image

After:

image

Copy link
Contributor

@mgravell mgravell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore previous comments: you'd already done what I suggested, I just misread the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants