Update examples to the latest otelgrpc API #729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods are currently using deprecated methods. This updates the examples to call the new APIs. Also required updating to the latest otelgrpc, since the methods were not deprecated in the previous version. Fixes grpc-ecosystem#728
Contributor
Author
|
@johanbrandhorst not exactly sure what's going on with the linter ... any ideas? |
johanbrandhorst
approved these changes
Oct 25, 2024
Collaborator
johanbrandhorst
left a comment
johanbrandhorst
left a comment
There was a problem hiding this comment.
Not sure what's up with the linter, there are no README changes here
Collaborator
|
Thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The methods are currently using deprecated methods. This updates the examples to call the new APIs.
Also required updating to the latest otelgrpc, since the methods were not deprecated in the previous version.
Verification
I ran the steps in the examples README locally.
Fixes #728