Added collapse long trip warning messages #524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed ✔️
app/src/main/java/de/grobox/transportr/departures/DepartureViewHolder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@TheLastProject fixed unintentional tabs to spaces |
Owner
|
@anjandev thanks a lot for the PR! Are these "Expand" links always shown, or only when the text exceeds a certain lenght? |
grote
reviewed
Oct 13, 2018
| </attr> | ||
| </declare-styleable> | ||
|
|
||
| </resources> |
Owner
There was a problem hiding this comment.
Why do we need to add this? I don't really understand the chinese on the libraries' page.
Contributor
Author
|
Torsten Grote <[email protected]> writes:
@anjandev thanks a lot for the PR!
No problem. Thank you for reviewing.
Are these "Expand" links always shown, or only when the text exceeds a certain lenght?
Expand is only shown when text exceeds a certain length.
See:
https://user-images.githubusercontent.com/8602360/46909957-af371980-cf2a-11e8-926d-e9cf8cf58eee.png
Why do we need to add this? I don't really understand the chinese on the libraries' page.
I dont understand chinese either but this was the only library I could
make work. Furthermore, this library allows us to have the simpliest
code.
I deleted the attr file and the code compiles and runs fine. I just made
a new commit deleting the attr file.
Thanks for the feedback.
|
Contributor
Author
|
@grote Is there any reason this was never merged and is there anything I can do to get it into a state that can be merged? |
Owner
|
Where does the What happens if some notices are expanded and some or not and you rotate the screen? Does this library maintain the expanded state across configuration changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses library: https://github.com/Carbs0126/ExpandableTextView
This gif was made with commit 09f451a (test code).
Test code was then removed with commit: 39f4f0f.
Fixes issue #422.