Skip to content

fixed a type definition error #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 15, 2019
Merged

fixed a type definition error #170

merged 1 commit into from
May 15, 2019

Conversation

@taromurao
Copy link
Contributor

@taromurao taromurao commented May 9, 2019 

ignoreEventsCondition?: (KeyboardEvent) => boolean,

should be

ignoreEventsCondition?: (keyEvent: KeyboardEvent) => boolean,

@greena13
Copy link
Owner

greena13 commented May 15, 2019

Thanks for this correction, @taromurao. From what I understand, this indeed looks correct.

@greena13 greena13 merged commit c63111a into greena13:master May 15, 2019
@greena13
Copy link
Owner

greena13 commented May 29, 2019

Fix is now available in v2.0.0-pre6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taromurao @greena13