Open Sourced CarbonDB and PowerHOG #1441
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* main: (feat): Added internal self tests for test data validity Removing confusing info that message was transported via email Update cron schedule and randomize URL input in GitHub Action for testing webNRG
Member
Author
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Comment on lines
+1014
to
+1018
| carbon_intensity_g_per_kWh = get_carbon_intensity(latitude, longitude) # cached | ||
|
|
||
| energy_J = float(data['energy_uj']) / 1e6 | ||
| energy_kWh = energy_J / (3_600*1_000) | ||
| carbon_kg = (energy_kWh * carbon_intensity_g_per_kWh)/1_000 |
Contributor
There was a problem hiding this comment.
logic: get_carbon_intensity() returns -1 on error but this negative value is used directly in carbon calculation without validation, resulting in negative carbon_kg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greptile Overview
Greptile Summary
Moved CarbonDB and PowerHOG features from enterprise (
ee/) to open source, making them publicly available through new API routes and frontend interfaces.Major changes:
Critical issues found:
api/carbondb.py:187where table column names are interpolated directly into queries/v2/carbondbendpoint - comma-separated values aren't validated as integers before database castingcarbondb_add()where negative carbon intensity values (-1error codes) propagate into calculations, resulting in negative carbon measurementsOther concerns:
escapeString()function