[v18] Refactor dynamoDB event queries to use proper pagination solution#62890
Merged
kshi36 merged 7 commits intobranch/v18from Jan 21, 2026
Merged
[v18] Refactor dynamoDB event queries to use proper pagination solution#62890kshi36 merged 7 commits intobranch/v18from
kshi36 merged 7 commits intobranch/v18from
Conversation
github-actions
bot
added
audit-log
kshi36
commented
Jan 15, 2026
Comment on lines
-1635
to
+1646
| if !l.foundStart { | ||
| // Support reading old checkpoints that are using checkpointKey.EventKey. | ||
| // This field was used to resume processing events after a sub-page break. | ||
| // After we begin processing from the correct event, | ||
| // new checkpoints will not set EventKey and use Iterator instead. | ||
| if l.checkpoint.EventKey != "" { |
Contributor
Author
There was a problem hiding this comment.
Since new checkpoints can resume directly from checkpoint.Iterator, we can change foundStart functionality to simply check if checkpoint.EventKey is populated. As such, we can remove foundStart
hugoShaka
approved these changes
Jan 21, 2026
bernardjkim
approved these changes
Jan 21, 2026
public-teleport-github-review-bot
bot
removed the request for review
from tigrato
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #62659 to branch/v18
This backport includes manual changes to re-add the old pagination solution, in order to read old checkpoints using
checkpointKey.EventKeyfield. While we support reading inEventKey, new checkpoints will not use this field and set checkpoints usingcheckpointKey.Iteratorinstead.changelog: Improved performance of large search queries for DynamoDB event backend