Replace assert with require in host user integration tests
#58739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktate
added
no-changelog
eriktate
changed the title
assert with require in hos tuser integration testsassert with require in host user integration tests
rosstimothy
reviewed
Sep 4, 2025
Contributor
There was a problem hiding this comment.
I think we should revert the mass conversion from assert to require in the spirit of keep-going. The one place we either need to use require, or return if an assert.NoError fails is in the EventuallyWithT blocks to prevent panics like
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x16e7d0f9]
goroutine 15065 [running]:
github.com/gravitational/teleport/integration.testStaticHostUsers.func2(0xc00428bad0)
/__w/teleport/teleport/integration/hostuser_test.go:879 +0xd9
github.com/stretchr/testify/assert.EventuallyWithT.func1()
/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:2096 +0xb8
created by github.com/stretchr/testify/assert.EventuallyWithT in goroutine 5479
/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:2108 +0x27d
The above comment applied to the original commit which has since been resolved by the squashed commit.
…host user integration tests
eriktate
force-pushed
the
eriktate/fix-hostuser-assertions
branch
from
6efdba1 to
f6bd24e
Compare
rosstimothy
approved these changes
Sep 4, 2025
cthach
reviewed
Sep 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
mmcallister
pushed a commit
that referenced
this pull request
Sep 22, 2025
…host user integration tests (#58739)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.