Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
f6ed24a to
3c2c21d
Compare
|
This PR emerged from #4258 => but note that comment at #4258 (comment) by @JoviDeCroock notes remaining reservation with respect to the modified prefix. I have left this PR in draft, because considering the above mentioned reservation, I am not sure if we consider it better than the status quo. An argument could be made that the status quo is sufficient: although the AbortError is not technically thrown, depending on the implementation, it could have been, as we could have implemented it as a thrown error simply by using This PR is also another breaking change, technically, although hopefully it doesn't hit too many people, as since I do not like our current state of error wrapping at all, see discussion at |
|
Closing this for now, we can always reopen if desired. |
should encompass thrown errors and encountered abort errors