Skip to content

[v4] remove disableTabs option #3687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 7, 2024
Merged

[v4] remove disableTabs option #3687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1aa8cc
remove `disableTabs` option
dimaMachina Aug 7, 2024
8d94ec0
format
dimaMachina Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/green-pugs-worry.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'graphiql': major
---

remove `disableTabs` option
94 changes: 44 additions & 50 deletions packages/graphiql/src/components/GraphiQL.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ export function GraphiQL({
>
<GraphiQLInterface
showPersistHeadersSettings={shouldPersistHeaders !== false}
disableTabs={props.disableTabs ?? false}
forcedTheme={props.forcedTheme}
{...props}
/>
Expand Down Expand Up @@ -218,7 +217,6 @@ export type GraphiQLInterfaceProps = WriteableEditorProps &
* settings modal.
*/
showPersistHeadersSettings?: boolean;
disableTabs?: boolean;
/**
* forcedTheme allows enforcement of a specific theme for GraphiQL.
* This is useful when you want to make sure that GraphiQL is always
Expand Down Expand Up @@ -544,55 +542,51 @@ export function GraphiQLInterface(props: GraphiQLInterfaceProps) {
)}
<div ref={pluginResize.secondRef} className="graphiql-sessions">
<div className="graphiql-session-header">
{!props.disableTabs && (
<>
{hasMultipleTabs && (
<Tabs
values={editorContext.tabs}
onReorder={handleReorder}
aria-label="Select active operation"
>
{editorContext.tabs.map((tab, index) => (
<Tooltip key={tab.id} label={tab.title}>
<Tab
value={tab}
isActive={index === editorContext.activeTabIndex}
>
<Tab.Button
aria-controls="graphiql-session"
id={`graphiql-session-tab-${index}`}
onClick={() => {
executionContext.stop();
editorContext.changeTab(index);
}}
>
{tab.title}
</Tab.Button>
<Tab.Close
onClick={() => {
if (editorContext.activeTabIndex === index) {
executionContext.stop();
}
editorContext.closeTab(index);
}}
/>
</Tab>
</Tooltip>
))}
</Tabs>
)}
<Tooltip label="New tab">
<UnStyledButton
type="button"
className="graphiql-tab-add"
onClick={handleAddTab}
aria-label="New tab"
>
<PlusIcon aria-hidden="true" />
</UnStyledButton>
</Tooltip>
</>
{hasMultipleTabs && (
<Tabs
values={editorContext.tabs}
onReorder={handleReorder}
aria-label="Select active operation"
>
{editorContext.tabs.map((tab, index) => (
<Tooltip key={tab.id} label={tab.title}>
<Tab
value={tab}
isActive={index === editorContext.activeTabIndex}
>
<Tab.Button
aria-controls="graphiql-session"
id={`graphiql-session-tab-${index}`}
onClick={() => {
executionContext.stop();
editorContext.changeTab(index);
}}
>
{tab.title}
</Tab.Button>
<Tab.Close
onClick={() => {
if (editorContext.activeTabIndex === index) {
executionContext.stop();
}
editorContext.closeTab(index);
}}
/>
</Tab>
</Tooltip>
))}
</Tabs>
)}
<Tooltip label="New tab">
<UnStyledButton
type="button"
className="graphiql-tab-add"
onClick={handleAddTab}
aria-label="New tab"
>
<PlusIcon aria-hidden="true" />
</UnStyledButton>
</Tooltip>
{logo}
</div>
<div
Expand Down