Skip to content

Conversation

@iahu
Copy link
Contributor

@iahu iahu commented Oct 13, 2021

build es module code with esNext module type.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2021

🦋 Changeset detected

Latest commit: 443abd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
graphql-language-service Patch
monaco-graphql Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 13, 2021

CLA Signed

The committers are authorized under a signed CLA.

@iahu iahu changed the title fix: es module config fix: es module config should use esNext Oct 13, 2021
@acao
Copy link
Member

acao commented Oct 13, 2021

just for monaco-graphql?

@codecov
Copy link

codecov bot commented Oct 13, 2021

Codecov Report

Merging #1979 (443abd8) into main (2d91916) will increase coverage by 0.70%.
The diff coverage is 68.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1979      +/-   ##
==========================================
+ Coverage   65.70%   66.40%   +0.70%     
==========================================
  Files          85       86       +1     
  Lines        5106     5153      +47     
  Branches     1631     1643      +12     
==========================================
+ Hits         3355     3422      +67     
+ Misses       1747     1727      -20     
  Partials        4        4              
Impacted Files Coverage Δ
...ackages/graphiql-toolkit/src/create-fetcher/lib.ts 51.78% <27.27%> (-7.79%) ⬇️
packages/graphiql/src/utility/HistoryStore.ts 62.26% <62.26%> (ø)
...ql-language-service-server/src/MessageProcessor.ts 66.58% <66.66%> (+6.30%) ⬆️
packages/graphiql/src/components/QueryHistory.tsx 73.91% <76.47%> (+6.69%) ⬆️
...iql/src/components/DocExplorer/MarkdownContent.tsx 100.00% <100.00%> (ø)
packages/graphiql/src/components/GraphiQL.tsx 58.34% <100.00%> (+0.83%) ⬆️
...hql-language-service-server/src/findGraphQLTags.ts 67.64% <100.00%> (+7.00%) ⬆️
...raphql-language-service-parser/src/onlineParser.ts 87.23% <0.00%> (-3.14%) ⬇️
...kages/graphql-language-service-parser/src/Rules.ts 96.80% <0.00%> (-0.97%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a5dae...443abd8. Read the comment docs.

@acao acao changed the title fix: es module config should use esNext fix: monaco-graphql es module config should use esNext Oct 13, 2021
@iahu
Copy link
Contributor Author

iahu commented Oct 13, 2021

Yes, I have checked other packages, it seems that only monaco-graphql need changing.

@iahu
Copy link
Contributor Author

iahu commented Oct 18, 2021

because it's a very little commit, so I want push an update commit to fix another issue on this PR.

the second update is:

fix failed to load graphql worker module on monaco-editor

@acao
Copy link
Member

acao commented Oct 18, 2021

@iahu thank you!

@iahu
Copy link
Contributor Author

iahu commented Oct 18, 2021

monaco-graphql is very nice, thanks your great work.

please check dose this PR has any side effect on AMD module type codes.

@acao
Copy link
Member

acao commented Oct 29, 2021

this makes a lot more sense now, my bad, the esm build should use esm of course!

@acao acao changed the title fix: monaco-graphql es module config should use esNext fix: monaco-graphql worker issue, es module config should use esNext Oct 29, 2021
@acao acao merged commit 0e2c1a0 into graphql:main Oct 29, 2021
@github-actions github-actions bot mentioned this pull request Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

2 participants