-
Notifications
You must be signed in to change notification settings - Fork 1.8k
fix: monaco-graphql worker issue, es module config should use esNext
#1979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 443abd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
just for |
Codecov Report
@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
+ Coverage 65.70% 66.40% +0.70%
==========================================
Files 85 86 +1
Lines 5106 5153 +47
Branches 1631 1643 +12
==========================================
+ Hits 3355 3422 +67
+ Misses 1747 1727 -20
Partials 4 4
Continue to review full report at Codecov.
|
esNext monaco-graphql es module config should use esNext
|
Yes, I have checked other packages, it seems that only monaco-graphql need changing. |
|
because it's a very little commit, so I want push an update commit to fix another issue on this PR. the second update is: fix failed to load graphql worker module on monaco-editor |
|
@iahu thank you! |
|
please check dose this PR has any side effect on |
|
this makes a lot more sense now, my bad, the esm build should use esm of course! |
monaco-graphql es module config should use esNext monaco-graphql worker issue, es module config should use esNext
build es module code with
esNextmodule type.