-
Notifications
You must be signed in to change notification settings - Fork 441
[GraphQL October 2021] Support @specifiedBy(url: "...") directive (#1000)
#1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FCM |
@specifiedBy(url: "...") directive@specifiedBy(url: "...") directive (#1000)
# Conflicts: # juniper/src/schema/meta.rs
@specifiedBy(url: "...") directive (#1000)@specifiedBy(url: "...") directive (#1000)
# Conflicts: # juniper/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilslv overall is good, but let's do some additional adjustments:
- Check during proc macro expansion whether the given literal is valid URL via
Url::parse(). - Add codegen failure tests to cover the case where invalid URL is specified.
UPD: I also cannot grasp where the specifiedByUrl directive is inserted into __Schema. It's missed in the introspection query results, while the spec requires it being present. I do see where new_skip and new_include are used though.
tyranron
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilslv there is also @deprecated directive is missing in __Schema when intospected. Please, fix in a separate PR.
Part of #1000
Synopsis
RFC
Solution
Add
specified_by_urlattribute toScalarimpl and derive macros.Checklist
Draft:prefixDraft:prefix is removed