Skip to content

Conversation

@Shane32
Copy link
Member

@Shane32 Shane32 commented Jan 7, 2023

  • Faster build checks
  • Allows to see formatting problems separate from test failures
  • Same as server repo

@Shane32 Shane32 self-assigned this Jan 7, 2023
@github-actions github-actions bot added the CI CI configuration issue or pull request label Jan 7, 2023
@sungam3r
Copy link
Member

sungam3r commented Jan 8, 2023

graphql-dotnet/authorization#254 (comment)

OK, I'm fine with moving formatting into new workflow. Just want to clarify merge button behavior. Format check failed. Merge button is green. Right? Good behavior or not?

@codecov-commenter
Copy link

Codecov Report

Merging #3491 (a52a794) into master (749ebee) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3491   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         379      379           
  Lines       16626    16626           
  Branches     2663     2663           
=======================================
  Hits        13948    13948           
  Misses       2043     2043           
  Partials      635      635           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Shane32
Copy link
Member Author

Shane32 commented Jan 8, 2023

graphql-dotnet/authorization#254 (comment)

OK, I'm fine with moving formatting into new workflow. Just want to clarify merge button behavior. Format check failed. Merge button is green. Right? Good behavior or not?

Either way, I'll fix the formatting before merging. As we are both admins of the repo, and can merge regardless of build checks, and as there are no other contributors currently, it makes little difference if there are merge restrictions.

@sungam3r
Copy link
Member

sungam3r commented Jan 8, 2023

I expected such an answer. OK. I'm done with reviews today. 3:20 AM.

@Shane32 Shane32 merged commit 6e19c00 into master Jan 8, 2023
@Shane32 Shane32 deleted the formatting branch January 8, 2023 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI configuration issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants