Multi version targeting of GraphQL.NET #88
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test
Shane32
changed the title
joemcbride
approved these changes
Nov 2, 2020
sungam3r
reviewed
Nov 2, 2020
sungam3r
reviewed
Nov 2, 2020
sungam3r
reviewed
Nov 2, 2020
sungam3r
reviewed
Nov 2, 2020
sungam3r
reviewed
Nov 2, 2020
sungam3r
approved these changes
Nov 2, 2020
sungam3r
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we are not going to have a "mono repo", we should target the oldest compatible version of GraphQL.Net. For this repo, 3.0.0. We can run tests against the latest version of GraphQL.Net, however, and this PR is a demonstration of running tests against multiple versions of the GraphQL.Net library.
These changes compile the authorization library to run against >=3.0.0 but then runs tests against all these versions on both windows and ubuntu:
Locally the tests are configured to run against 3.1.3.
This now is the true benefit of separate repos, where people can select a new version of one component without updating the rest of their references. (The increased testing is really just a bonus.)
Note: required status checks needs to change to "all-tests"