Small cleanup #87
Merged
Small cleanup #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
more cleanup
… cleanup # Conflicts: # README.md # appveyor.yml # src/GraphQL.Authorization.Tests/AuthenticatedUserRequirementTests.cs # src/GraphQL.Authorization.Tests/AuthorizationEvaluatorTests.cs # src/GraphQL.Authorization.Tests/AuthorizationSchemaBuilderTests.cs # src/GraphQL.Authorization.Tests/AuthorizationSettingsTests.cs # src/GraphQL.Authorization.Tests/AuthorizationValidationRuleTests.cs # src/GraphQL.Authorization.Tests/ClaimAuthorizationRequirementTests.cs # src/GraphQL.Authorization.Tests/GraphQL.Authorization.Tests.csproj # src/GraphQL.Authorization.Tests/ValidationTestBase.cs # src/GraphQL.Authorization.sln # src/GraphQL.Authorization/AuthorizationEvaluator.cs # src/GraphQL.Authorization/AuthorizationMetadataExtensions.cs # src/GraphQL.Authorization/AuthorizationPolicyBuilder.cs # src/GraphQL.Authorization/AuthorizationValidationRule.cs # src/GraphQL.Authorization/GraphQL.Authorization.csproj # src/GraphQL.Authorization/Requirements/ClaimAuthorizationRequirement.cs # src/Harness/GraphQLAuthExtensions.cs # src/Harness/Harness.csproj # src/Harness/Program.cs # src/Harness/Properties/launchSettings.json # src/Harness/Startup.cs
github-actions
bot
added
the
test
sungam3r
requested review from
Shane32 and
joemcbride
and removed request for
Shane32 and
joemcbride
Member
|
I have not used this repo @sungam3r |
Member
Author
|
Don't I bother you with the review anymore? |
sungam3r
added
code style
Member
|
I don’t mind if you tag me of course. But I don’t have the knowledge or time to give a comprehensive review. When I’m able, I’ll skim over the changes and give it the 👍 but I won’t really know how any of the changes affect users. (Basically I only focus on changes to the main repo at present) |
sungam3r
commented
Nov 1, 2020
...GraphQL.Authorization.ApiTests/ApiApprovalTests.PublicApi.GraphQL.Authorization.approved.txt
Show resolved
Hide resolved
sungam3r
commented
Nov 1, 2020
Member
Author
|
@joemcbride PR is ready for review, no breaking changes, one bugfix, many xml docs and some memory optimizations. I have reduced the number of changed files. After this PR is merged I will continue working on #62. There are backward incompatible changes. Maybe I'll make |
joemcbride
requested changes
Nov 2, 2020
Member
Author
|
@joemcbride OK to merge? |
Shane32
reviewed
Nov 2, 2020
Shane32
reviewed
Nov 2, 2020
joemcbride
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework of #62 . No breaking changes. Fixes #61 , slight style changes.