Fix security flaw with nested fragments #256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+51
to
+52
| if ((node is GraphQLOperationDefinition astType && astType == context.Operation) || | ||
| (node is GraphQLFragmentDefinition fragment && (context.GetRecursivelyReferencedFragments(context.Operation)?.Contains(fragment) ?? false))) |
Check notice
Code scanning / CodeQL
Complex condition
Member
|
Looks like a huge simplification. |
sungam3r
approved these changes
Jan 10, 2023
Member
Author
|
@sungam3r merge here or merge your pr - either way. I will be busy until late tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This targets
bumpbut once PR #254 is merged, I can update it to targetmaster. Or it can be merged intobump.This fixes the security flaw where nested fragments are not processed for authentication when there are multiple operations in the document.
It should also run faster than the previous implementation, and reduces the complexity of the implementation.