Skip to content

Conversation

@Shane32
Copy link
Member

@Shane32 Shane32 commented Jan 8, 2023

This PR targets bump / PR #254

  • Use ExecutionOptions.User for ClaimsPrincipal if user context does not implement IProvideClaimsPrincipal
  • Asynchronous execution of policies, eliminating all calls to GetAwaiter().GetResult()
  • No API changes
  • Add note to readme regarding unsupported features and ASP.NET Core compatibility
  • Separate format check from tests
  • Add note that this implementation has a critical security flaw

There's really very little code changes; mostly just refactoring.

Tests run locally but don't run because this PR doesn't target master or develop.

Hide whitespace to reduce the diff

@Shane32 Shane32 requested a review from sungam3r January 8, 2023 02:47
@Shane32 Shane32 self-assigned this Jan 8, 2023
@github-actions github-actions bot added CI CI configuration issue or pull request documentation labels Jan 8, 2023
@Shane32
Copy link
Member Author

Shane32 commented Jan 8, 2023

@sungam3r Feel free to merge into your PR and continue to make changes as desired.

@sungam3r
Copy link
Member

sungam3r commented Jan 8, 2023

Thanks.

Use ExecutionOptions.User for ClaimsPrincipal if user context does not implement IProvideClaimsPrincipal

I would like to remove IProvideClaimsPrincipal at all. I see no sense to duplicate API that was added in the root lib.

@sungam3r sungam3r merged commit 85b2e4d into bump Jan 8, 2023
@sungam3r sungam3r deleted the addl branch January 8, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI configuration issue or pull request documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants