Updates for the latest GraphQL.NET bits #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
added
bugfix
github-actions
bot
added
the
test
github-actions
bot
added
CI
Codecov Report
@@ Coverage Diff @@
## develop #191 +/- ##
===========================================
- Coverage 83.60% 80.34% -3.26%
===========================================
Files 9 10 +1
Lines 250 290 +40
Branches 41 46 +5
===========================================
+ Hits 209 233 +24
- Misses 32 45 +13
- Partials 9 12 +3
Continue to review full report at Codecov.
|
Shane32
approved these changes
Jan 1, 2022
Member
Shane32
left a comment
Shane32
left a comment
There was a problem hiding this comment.
I think, either in this PR or another, we should also include the input extensions
| public System.Collections.Generic.IReadOnlyDictionary<string, object>? Inputs { get; set; } | ||
| public System.Security.Claims.ClaimsPrincipal? User { get; set; } | ||
| public System.Collections.Generic.IDictionary<string, object?>? UserContext { get; set; } | ||
| public GraphQL.Inputs? Variables { get; set; } |
Member
Author
There was a problem hiding this comment.
IDocumentValidator has no access to extensions. Another PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.