Add GraphQLBuilder method called AddAuthorization #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test
Member
|
I'll try to review a bunch PRs including graphql-dotnet/server#602 in the next days. |
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
==========================================
- Coverage 82.00% 78.71% -3.30%
==========================================
Files 9 10 +1
Lines 239 249 +10
Branches 36 36
==========================================
Hits 196 196
- Misses 33 43 +10
Partials 10 10
Continue to review full report at Codecov.
|
Member
|
Reminder - maybe add some DI API around |
sungam3r
approved these changes
Dec 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately until graphql-dotnet/server#602 is merged and released, the builder methods cannot be used within the Harness project because it relies on GraphQL.Server which has not been updated to support
GraphQL.DI.IGraphQLBuilder.