Skip to content

Conversation

@sungam3r
Copy link
Member

  1. NET6 for CI, tests and examples
  2. enable dependabot for github-actions
  3. embedded readme
  4. apply ShouldBeSkipped for VariableReference in AuthorizationValidationRule

…; embedded readme; apply ShouldBeSkipped for VariableReference branch
@github-actions github-actions bot added CI CI configuration issue or pull request test Pull request that adds new or changes existing tests labels Dec 12, 2021
@sungam3r sungam3r self-assigned this Dec 12, 2021
@sungam3r sungam3r requested a review from Shane32 December 12, 2021 19:04
@sungam3r sungam3r added this to the 5.0 milestone Dec 12, 2021
dotnet format --check -v diag --fix-style warn --fix-analyzers warn || (echo "Run 'dotnet format' to fix formatting issues" && exit 1)
dotnet format --no-restore --verify-no-changes -v diag --severity warn whitespace || (echo "Run 'dotnet format' to fix whitespace issues" && exit 1)
dotnet format --no-restore --verify-no-changes -v diag --severity warn analyzers || (echo "Run 'dotnet format' to fix analyzers issues" && exit 1)
dotnet-format --no-restore --verify-no-changes -v diag --severity warn style || (echo "Run 'dotnet format' to fix style issues" && exit 1)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to add this line to GraphQL.NET repo too.

@sungam3r sungam3r added bugfix Pull request that fixes a bug code style Pull request that applies code style rules and removed test Pull request that adds new or changes existing tests labels Dec 12, 2021
@github-actions github-actions bot added the test Pull request that adds new or changes existing tests label Dec 12, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #184 (620fcb9) into develop (c853fe1) will not change coverage.
The diff coverage is 71.42%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #184   +/-   ##
========================================
  Coverage    83.81%   83.81%           
========================================
  Files            9        9           
  Lines          278      278           
  Branches        46       46           
========================================
  Hits           233      233           
  Misses          33       33           
  Partials        12       12           
Impacted Files Coverage Δ
...aphQL.Authorization/AuthorizationValidationRule.cs 94.95% <0.00%> (ø)
...ation/Requirements/AuthenticatedUserRequirement.cs 75.00% <0.00%> (ø)
src/GraphQL.Authorization/AuthorizationPolicy.cs 85.71% <100.00%> (ø)
...raphQL.Authorization/AuthorizationPolicyBuilder.cs 45.45% <100.00%> (ø)
src/GraphQL.Authorization/AuthorizationResult.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c853fe1...620fcb9. Read the comment docs.

@sungam3r sungam3r merged commit 12fb6f6 into develop Dec 12, 2021
@sungam3r sungam3r deleted the net6 branch December 12, 2021 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Pull request that fixes a bug CI CI configuration issue or pull request code style Pull request that applies code style rules test Pull request that adds new or changes existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants