NRT #181
Merged
NRT #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test
sungam3r
added
enhancement
sungam3r
commented
Dec 11, 2021
| // validation rule should check that but here we should just ignore that | ||
| // "unknown" field. | ||
| if (context.Inputs.TryGetValue(variableRef.Name, out object input) && | ||
| if (context.Inputs != null && |
Member
Author
There was a problem hiding this comment.
@Shane32 NRT helps find bug here - NRE before context.Inputs check, see passes_with_claim_on_variable_type_without_inputs_but_fails_later_either. I'll backport this check into master.
sungam3r
commented
Dec 11, 2021
github-actions
bot
added
the
test
Codecov Report
@@ Coverage Diff @@
## develop #181 +/- ##
===========================================
- Coverage 84.47% 83.81% -0.67%
===========================================
Files 9 9
Lines 277 278 +1
Branches 45 46 +1
===========================================
- Hits 234 233 -1
Misses 33 33
- Partials 10 12 +2
Continue to review full report at Codecov.
|
Merged
Shane32
approved these changes
Dec 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.