Skip to content

Move to fetchPriority for eagerly loading images instead of using <link rel=preload/> #2174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Move to fetchPriority for eagerly loading images instead of using <link rel=preload/> #2174

wants to merge 2 commits into from

Conversation

@paales
Copy link
Member

@paales paales commented Jan 22, 2024 •
edited
Loading

It seems that the images are getting pushed down the loading order, making the being loaded later in the loading order.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b420d2b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
graphcommerce ✅ Ready (Inspect) Visit Preview Jan 22, 2024 10:39am
graphcommerce-hygraph-dynamic-rows-ui ✅ Ready (Inspect) Visit Preview Jan 22, 2024 10:39am

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Page Size old Size new Size diff First load old First load new First load diff
/blog/tagged/[url] 1.6kB 1.6kB 296kB 295.0kB -1kB
/p/[url] 21.9kB 21.9kB 338kB 337.0kB -1kB
/test/buttons 5.1kB 5.1kB 219kB 218.0kB -1kB
/test/icons 4.7kB 4.7kB 225kB 224.0kB -1kB
/test/sheet 5.0kB 5.0kB 233kB 232.0kB -1kB

@paales paales force-pushed the fix/fetch-priority branch from 8f0b640 to 2a7b22a Compare January 22, 2024 10:11
@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Page Size old Size new Size diff First load old First load new First load diff
/blog/tagged/[url] 1.6kB 1.6kB 296kB 295.0kB -1kB
/p/[url] 21.9kB 21.9kB 338kB 337.0kB -1kB
/test/buttons 5.1kB 5.1kB 219kB 218.0kB -1kB
/test/icons 4.7kB 4.7kB 225kB 224.0kB -1kB
/test/sheet 5.0kB 5.0kB 233kB 232.0kB -1kB

@github-actions
Copy link
Contributor

github-actions bot commented Jan 22, 2024

Page Size old Size new Size diff First load old First load new First load diff
/blog/tagged/[url] 1.6kB 1.6kB 296kB 295.0kB -1kB
/p/[url] 21.9kB 21.9kB 338kB 337.0kB -1kB
/test/buttons 5.1kB 5.1kB 219kB 218.0kB -1kB
/test/icons 4.7kB 4.7kB 225kB 224.0kB -1kB
/test/sheet 5.0kB 5.0kB 233kB 232.0kB -1kB

@paales paales closed this Apr 22, 2024
@paales paales deleted the fix/fetch-priority branch December 16, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paales