Fix all remaining hlint lints#310
Merged
dorchard merged 15 commits intogranule-project:mainfrom Feb 26, 2026
Merged
Conversation
BinderDavid
force-pushed
the
fix-hlint-in-frontend
branch
from
6f95842 to
45ee9e0
Compare
Contributor
Author
8 out of 483 tests failed (110.55s)This is exactly the same number as in the |
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes or explicitly ignores 628 hlint hints that are currently in the codebase.
After this PR has been merged we can run hlint without any warnings:
Next step would be to enable hlint in CI so that we don't accidentally add code that the linter complains about.