-
Notifications
You must be signed in to change notification settings - Fork 129
Fixes for the commands plugin (#1142 but only the fixes) #1189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🚀 Deployed on https://68a0dff68493ac3fb61871a8--grammy.netlify.app |
carafelix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of my comments may fall somewhat outside the scope of this specific pr, but I think are worth noting.
Applied all suggestions. LGTM from now |
carafelix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
besides the space thing. LGTM
KnorpelSenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rubber-stamp LGTM
|
Finally this docs gonna be fixed 🎉 |
Co-authored-by: deptyped <[email protected]>
Co-authored-by: deptyped <[email protected]>
LWJerri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
I apologise if the PR is incorrect. It was based on #1142 (comment).
I may not have transferred all the fixes, or I may have transferred unnecessary ones. Please consider this PR