Displayed TabBar font and badge color props (iOS >= 13) #613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In ios 13 need to use appearance to style the tab bar. Still need the set title text attributes on tab bar item otherwise the font doesn't show properly on first load or when first switching tabs. So need both appearance in tab bar and title text attributes on tab bar item
Doesn't update if dynamically change the badge color (does after orientation change), but think this is v rare requirement. Also applied fonts and badge color when landscape. Doesn't completely work because the unselected tab doesn't get the fonts applied, but think would have to apply global item appearance for that https://stackoverflow.com/questions/71194968/setting-a-uitabbarappearance-breaks-uitabbaritem-appearance-proxy-font-size-when/71195176#71195176
grahammendick
added a commit
that referenced
this pull request
Jul 22, 2022
Forgot ios props have to be implemented in android view manager on Fabric. Also removed test id that made it in accidentally in copy paste of #613
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611
Used
TabBarAppearanceandTabBarItemAppearanceintroduced in iOS 13 because the old way doesn't work for font and badge color props