This repository was archived by the owner on Jan 30, 2025. It is now read-only.
Fix web vital trace test #1262
Merged
Fix web vital trace test #1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of a sleep to wait for a web vital, which may be delayed for various reasons, and can cause the sub test to fail, catch the web vital spans that are emitted/received when the page.close() API is called.
This was referenced Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Catch the web vital spans after the
page.closeAPI call is made. This should definitely cause the web vitals to emit and be received in time before the sub-test completes.Why?
Instead of a sleep to wait for a web vital, which is problematic on slower machines that can cause the sub test to fail, catch the web vital spans that are emitted/received when the page.close() API is called.
I've ran the integration tests 10 times and there were no failures with the tracing tests, whereas usually I would get 2-3 failures.
Checklist
Related PR(s)/Issue(s)
#1150