Skip to content

feat: support signing of private plugins #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: support signing of private plugins #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03998ab
Allow passing rootUrls when signing plugins
StephenKing Nov 1, 2025
4718e60
Support passing arguments to npm run
StephenKing Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions build-plugin/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ inputs:
description: "Grafana access policy token. https://grafana.com/developers/plugin-tools/publish-a-plugin/sign-a-plugin#generate-an-access-policy-token"
required: false
default: ""
sign_root_urls:
description: "Root URLs for plugin signing"
required: false
default: ""
grafana_token:
description: "[deprecated] Grafana API Key to sign a plugin. Prefer `policy_token`."
required: false
Expand Down Expand Up @@ -67,6 +71,7 @@ runs:
uses: grafana/plugin-actions/package-plugin@main # zizmor: ignore[unpinned-uses]
with:
policy_token: ${{ inputs.policy_token }}
sign_root_urls: ${{ inputs.sign_root_urls }}
node-version: "${{ inputs.node-version }}"
go-version: "${{ inputs.go-version }}"
backend-target: "${{ inputs.backend-target }}"
Expand Down
13 changes: 12 additions & 1 deletion package-plugin/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ inputs:
description: "Grafana access policy token. https://grafana.com/developers/plugin-tools/publish-a-plugin/sign-a-plugin#generate-an-access-policy-token"
required: false
default: ""
sign_root_urls:
description: "Root URLs for plugin signing"
required: false
default: ""
go-version:
description: "Version of go"
required: false
Expand Down Expand Up @@ -100,7 +104,14 @@ runs:
shell: bash

- name: Sign plugin
run: ${{ github.action_path }}/pm.sh sign
run: |
if [ -n "${{ inputs.sign_root_urls }}" ]; then
echo "Signing private plugin including rootUrls"
${{ github.action_path }}/pm.sh sign -- --rootUrls "${{ inputs.sign_root_urls }}"
else
echo "Signing public plugin"
${{ github.action_path }}/pm.sh sign
fi
shell: bash
env:
GRAFANA_ACCESS_POLICY_TOKEN: ${{ inputs.policy_token }}
Expand Down
2 changes: 1 addition & 1 deletion package-plugin/pm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ echo "Running '$1' with $pm..."
if [ "$1" = "install" ]; then
"$pm" install
else
"$pm" run "$1"
"$pm" run "$1" -- "${@:3}"
fi