k6/execution:Don't panic on accessing test.options #3708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
olegbespalov and
oleiade
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3708 +/- ##
==========================================
+ Coverage 73.28% 73.30% +0.02%
==========================================
Files 278 278
Lines 20389 20392 +3
==========================================
+ Hits 14942 14949 +7
+ Misses 4497 4493 -4
Partials 950 950
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
olegbespalov
previously approved these changes
Apr 24, 2024
Contributor
olegbespalov
left a comment
olegbespalov
left a comment
There was a problem hiding this comment.
LGTM. Maybe we could use common.NewInitContextError helper.
olegbespalov
approved these changes
Apr 24, 2024
oleiade
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes a panic when accessing
k6/execution.test.options in the init context.Why?
Not to panic but give an exception.
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)