database_observability: add cloud provider labels to all metrics#5057
Closed
matthewnolf wants to merge 1 commit into
Closed
database_observability: add cloud provider labels to all metrics#5057matthewnolf wants to merge 1 commit into
matthewnolf wants to merge 1 commit into
Conversation
matthewnolf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Followup to #4942 - with verified git commit.
This change adds cloud provider information as labels to all metrics exported by the
database_observabilitycomponents. This enables more effective correlation and attribution across Grafana Cloud.Some of the implementation is duplicated across MySQL and Postgres components. The reasoning being that cloud-providers sometimes vary their naming / URI structure to include engine information. Keeping things strongly tied to the database engine helps make this determination easier.
Which issue(s) this PR fixes
Notes to the Reviewer
PR Checklist