-
Notifications
You must be signed in to change notification settings - Fork 5k
Add AWS SSO support, and bump AWS s3 sdk to latest AWS SDK v1 #34068
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ahmad Al-Masry <[email protected]>
|
Thank you for your proposed contribution! This PR has a valid DCO. The relevant team for this area will confirm the design of the implementation choices. |
|
Locally it can be tested easily by trying to build the project using gradle without cache on a device with AWS CLI configured with SSO credentials. |
|
We need to find a way to test this in an automated way. Adding more features to the S3-based repositories is not in scope right now for us. We haven't looked, but we also need to consider how this impacts moving to AWS SDK v2. Sorry, we probably won't look into this soon. |
|
Thank you for the note, but I would really appreciate reconsider this because of the following reasons:
Thank you again for your time and effort. |
|
Hi; |
|
We will likely not want to accept this change without tests |
|
Thank you @jvandort |
|
We have test infrastructure to mock an s3 endpoint And tests that utilize this test fixture I would expect to see a test that sets the proper env vars and verifies that those credentials are sent to the s3 server |
|
Thank you for your guidance. |
|
Hi |
Context
#34049
Add support to use S3 repos using AWS SSO
Contributor Checklist
<subproject>/src/integTest) to verify changes from a user perspective.<subproject>/src/test) to verify logic../gradlew sanityCheck../gradlew <changed-subproject>:quickTest.Reviewing cheatsheet
Before merging the PR, comments starting with