-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Fix custom js param
#12508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix custom js param
#12508
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
393a4db
fix js
dawoodkhan82 c84588e
add changeset
gradio-pr-bot 95ee50f
fix spa
dawoodkhan82 ebd0ebd
add changeset
gradio-pr-bot a0b37a3
Merge branch 'main' into fix-js
dawoodkhan82 f924674
fix
dawoodkhan82 8467cc2
Fix
freddyaboulton ba4c9e7
Merge branch 'main' into fix-js
freddyaboulton a85f55f
Fix
freddyaboulton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@self/app": patch | ||
| "@self/spa": patch | ||
| "gradio": patch | ||
| --- | ||
|
|
||
| fix:Fix custom `js` param |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -375,7 +375,15 @@ | |
| if (config.deep_link_state === "invalid") { | ||
| pending_deep_link_error = true; | ||
| } | ||
| if (config.js) { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was originally running in the other onMount block, but that one runs before the config is set so I was getting an error when running this locally. Pushed a fix and now its working |
||
| try { | ||
| const script = document.createElement("script"); | ||
| script.textContent = config.js; | ||
| document.head.appendChild(script); | ||
| } catch (e) { | ||
| console.error("Error executing custom JS:", e); | ||
| } | ||
| } | ||
| if (config.dev_mode) { | ||
| setTimeout(() => { | ||
| const { host } = new URL(api_url); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.