Open
Conversation
Signed-off-by: gpunathilell <gpunathilell@nvidia.com>
gpunathilell
changed the title
|
The description says this PR added support for vxlan_sport, vxlan_mask, vxlan_security. Seems to be only vxlan_security is added. Please update the description |
|
LGTM otherwise |
dgsudharsan
suggested changes
Mar 18, 2026
| attr.value.u8 = to_uint<uint8_t>(value); | ||
| break; | ||
| case SAI_SWITCH_TUNNEL_ATTR_VXLAN_UDP_SPORT_SECURITY: | ||
| // Config must use string "true" or "false" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduction of VxLAN switch tunnel params (vxlan_security)
What I did
setSwitchTunnelVxlanParams()and SWITCH_TABLE / swssconfig (e.g. vxlan.json), including thevxlan_securityboolean attribute.vxlan_securityinline insetSwitchTunnelVxlanParams(): accept only the strings"true"or"false". If the value is neither (e.g. empty or invalid), logSWSS_LOG_ERRORand default to false (same pattern as qosorchconvertBool).Why I did it
"true"/"false";vxlan_securityis parsed explicitly and invalid values are logged.How I verified it
vxlan_security"true"or"false"is applied correctly.vxlan_securityparsing:"true"→ true,"false"→ false; invalid/empty value logs ERROR and defaults to false.Details if related
"true"or"false"in JSON/config for boolean attributes (e.g."vxlan_security": "true"). Using JSON booleantrue/falsecan result in an empty value once stored in Redis, so string form is recommended.vxlan_securityattribute.