feat(notifier): sending notification concurrently #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idilhaq
force-pushed
the
sending-notif-async
branch
from
876c051 to
c090e7e
Compare
rahmatrhd
reviewed
Mar 19, 2024
idilhaq
force-pushed
the
sending-notif-async
branch
4 times, most recently
from
c679082 to
76e7459
Compare
idilhaq
changed the title
idilhaq
force-pushed
the
sending-notif-async
branch
from
76e7459 to
1871431
Compare
idilhaq
force-pushed
the
sending-notif-async
branch
6 times, most recently
from
679f8ed to
43b04f5
Compare
idilhaq
force-pushed
the
sending-notif-async
branch
from
57d41ab to
08da75f
Compare
idilhaq
force-pushed
the
sending-notif-async
branch
from
08da75f to
21554ec
Compare
rahmatrhd
reviewed
Jun 3, 2024
rahmatrhd
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sending notifications should be not be part of sync call as part of create appeal or update approval. For both these steps, audit log and sending notifications need not be part of synchronous call one by one since that would increase the entire time of the appeal flow. These two can be run concurrently.
Please refer to the issue #84 for the discussion.
Approach
Making the call async for slack notification by applying go concurrency when sending the message through notifier