feat: update to use node20 #61
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks like there is some issue with testing against zig 0.11.0, https://github.com/chenrui333/setup-zig/actions/runs/7296724152/job/19884920370 |
Signed-off-by: Rui Chen <[email protected]>
Signed-off-by: Rui Chen <[email protected]>
|
thanks for the PR! zig 0.11 changed the build system so i've pulled that out into #62. |
|
@goto-bus-stop also the setup action should be bumped to v3 per this upgrade. :) |
|
imo it's OK to treat this bump as non-breaking since the environment it runs in is known to be compatible (aside from self-hosted runners, maybe?) and the cost of a major version bump on actions is very high as most projects do not have dependabot configured for actions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is consistent with all the recent github action updates. (mostly in actions repos, like actions/checkout, actions/setup-node, etc.)
Node12 was deleted from runner. Node20 was added to Actions Runner on v2.308.0.
Node16 has en end of life on 11 Sep 2023.
This PR updates the default runtime to node20, rather then node16
relates to actions/runner#2732